betodealmeida commented on a change in pull request #16214:
URL: https://github.com/apache/superset/pull/16214#discussion_r687996850



##########
File path: superset/db_engine_specs/base.py
##########
@@ -1433,6 +1434,11 @@ def get_parameters_from_uri(
         cls, uri: str, encrypted_extra: Optional[Dict[str, Any]] = None
     ) -> BasicParametersType:
         url = make_url(uri)
+        query = {

Review comment:
       You can also do this:
   
   ```python
   query = dict(item for item in url.query.items() if item not in 
cls.encryption_parameters.items())
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to