michael-s-molina commented on a change in pull request #16252:
URL: https://github.com/apache/superset/pull/16252#discussion_r688773954
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -84,11 +81,54 @@ const StyledContainer = styled.div`
& > span {
color: ${theme.colors.grayscale.light1};
margin-left: ${theme.gridUnit * 4}px;
- margin-top: ${theme.gridUnit * 6}px;
}
}
- & .ant-tooltip-open {
+ & .viz-gallery {
+ border: 1px solid ${theme.colors.grayscale.light2};
+ border-radius: ${theme.gridUnit}px;
+ margin: ${theme.gridUnit}px 0px;
+ max-height: calc(100vh - ${ELEMENTS_EXCEPT_VIZ_GALLERY}px);
+ flex: 1;
+ }
+
+ & .footer {
+ flex: 1;
+ display: flex;
+ flex-direction: row;
+ justify-content: flex-end;
+ align-items: center;
+
+ & > span {
+ color: ${theme.colors.grayscale.light1};
+ margin-right: ${theme.gridUnit * 4}px;
+ }
+ }
+
+ &&&& .ant-steps-item-tail {
Review comment:
It's just a way to increase selector specificity. Generally, we use it
when we don't have a way to declare a class for an internal element, and
`!important` is not an option.
In this example, the original selector is:
```
.ant-steps-vertical > .ant-steps-item > .ant-steps-item-container >
.ant-steps-item-tail {
display: block;
}
```
With the `&&&&` we have a resulting selector with higher priority:
```
.css-130sj7k.css-130sj7k.css-130sj7k.css-130sj7k .ant-steps-item-tail {
display: none;
}
```
@rusackas Should I spend more time trying to make it simpler? I don't know
if we will find a more readable alternative. All the times that we did that, we
ended up with a bunch of nested selectors, which for me are less readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
