john-bodley opened a new pull request #16266:
URL: https://github.com/apache/superset/pull/16266


   ### SUMMARY
   
   Re-enabling the Pylint `raise-missing-from` check.
   
   Note one thing which was somewhat concerning whilst updating the code was a 
common theme of repeated code logic, i.e., there are multiple 
[`validate_json`](https://github.com/apache/superset/search?q=%22def+validate_json%22)
 method with identical (or near identical logic). Thankfully there is a 
`duplicate-code` Pylint check (currently disabled) which can prevent this from 
occurring in the future, however I sense there needs to be a collective effort 
to rectify the issue in the current code.
   
   ### TESTING INSTRUCTIONS
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: https://github.com/apache/superset/issues/9953
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to