villebro opened a new pull request #16272: URL: https://github.com/apache/superset/pull/16272
### SUMMARY Currently the time filter indicator shows filter box time filters as being applied despite being set to "No filter". This PR changes the legacy chart data endpoint to not add the time filter to "applied columns" if the time filter is set to "No filter". In addition, unit tests are added for all non-Druid functionality in `get_time_filter_status` as the function didn't have any unit tests, along with a dataset fixture that can be used with the new unit tests (=faster than the integration tests). Please note that for V1 charts the change is done in `superset-ui` (PR forthcoming). ### AFTER  ### BEFORE  ### TESTING INSTRUCTIONS 1. Create a filter box with a "No filter" time range and create a dashboard with it 2. Add a legacy chart to the dashboard 3. Notice the filter indicator showing the time range as applied. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
