geido opened a new pull request #16275:
URL: https://github.com/apache/superset/pull/16275


   ### SUMMARY
   This PR fixes an issue with the height of the table inside the Change 
dataset modal when the pagination is off, which was causing a blank space to 
appear.
   
   ### BEFORE
   
   
https://user-images.githubusercontent.com/60598000/129256458-4a582b35-11d2-42a0-afb0-c3911b5957d8.mp4
   
   ### AFTER
   
   
https://user-images.githubusercontent.com/60598000/129588511-5cba6d93-938a-4407-96e1-8a92ca96f213.mp4
   
   ### TESTING INSTRUCTIONS
   1. Open a chart in Explore
   2. Click on Change dataset
   3. Observe the table height and make sure there is no blank space at the 
bottom
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #16249
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to