PeterHenell opened a new pull request #16292:
URL: https://github.com/apache/superset/pull/16292


   ### SUMMARY
   Fixes Issue #14520 
   
   extraConfigs do not work for adding databases. This fixes that problem by 
adjusting the name of the yaml-file to-be-created 
    (configured in extraConfigs)  to match the filename mentioned by the 
initscript.
   
   This PR alligns them so that they are referencing the same name: 
**import_datasources.yaml**.
   
   ### TESTING INSTRUCTIONS
   Tested using Kind 0.11.1
   
   Add these lines in the values.yaml file.
   The configuration might fail if the trino database does not exist. Which 
means that the configuration value is actually read and processed.
   
   ```
   extraConfigs:
     import_datasources.yaml: |
       databases:
       - allow_csv_upload: true
         allow_ctas: true
         allow_cvas: true
         database_name: trino
         extra: "{\r\n    \"metadata_params\": {},\r\n    \"engine_params\": 
{},\r\n    \"\
           metadata_cache_timeout\": {},\r\n    
\"schemas_allowed_for_csv_upload\": []\r\n\
           }"
         sqlalchemy_uri: trino://trino:8080/hive/default
         tables: []
   ```
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ X] Has associated issue: 14520 
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to