eschutho opened a new pull request #16306: URL: https://github.com/apache/superset/pull/16306
### SUMMARY We were passing "TEXT" for all report_types and it was breaking dashboards which require a PNG report type. The result was that we were receiving emails with no image for dashboards. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before: <img width="906" alt="Screenshot_8_17_21__5_20_PM" src="https://user-images.githubusercontent.com/5186919/129817728-81c7d2c0-7231-4240-b7bc-00d1212a5a40.png";> after: <img width="942" alt="All_Mail__26_636_messages__19_366_unread_" src="https://user-images.githubusercontent.com/5186919/129817744-ef182a5d-49ef-493f-8a1d-ee2fc6a7f322.png";> ### TESTING INSTRUCTIONS create a report from a dashboard page and verify that the email has a png image in it. unit tests are currently in review in a separate pr. Will update them to add this functionality. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/5186919/129817728-81c7d2c0-7231-4240-b7bc-00d1212a5a40.png"](https://user-images.githubusercontent.com/5186919/129817728-81c7d2c0-7231-4240-b7bc-00d1212a5a40.png"){kind=link}
![https://user-images.githubusercontent.com/5186919/129817744-ef182a5d-49ef-493f-8a1d-ee2fc6a7f322.png"](https://user-images.githubusercontent.com/5186919/129817744-ef182a5d-49ef-493f-8a1d-ee2fc6a7f322.png"){kind=link}