kamalkeshavani-aiinside commented on issue #16140: URL: https://github.com/apache/superset/issues/16140#issuecomment-900917393
We already have very tiny grid for vertical size, so I thought making it available for horizontal size should be also ok. But if we want to avoid tiny horizontal grid as default, here is my suggestion(haven't checked full code yet): 1. Currently, we store the width of every chart as number of columns in dashboard since number of columns are fixed across all dashboards. 2. We can add an extra KV for new dashboards to store column count, default as 12. 3. Absence of this key(for existing dashboard) can be assumed as column count 12 and added when existing dashboard is edited. 3. Need to create a new UI where user can select the column count(only from multiples of 12?) for any dashboard, which will be saved in the new key. 4. Change of this column count in dashboard will update the chart width(round down when exact not possible, e.x, width of 7 columns with column count 24, will become 3 when column count changed to 12 and so on) Such implementation will not require db upgrade like in https://github.com/apache/superset/pull/4416. I can try to contribute for python code, but will need help for UI changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
