geido opened a new pull request #16324: URL: https://github.com/apache/superset/pull/16324
### SUMMARY This PR should definitely fix a problem with a blank space appearing at the bottom of the Change dataset modal when closing the top warning whether pagination is on or off. ### BEFORE https://user-images.githubusercontent.com/60598000/129912683-3efe2209-268f-4985-ba54-8368536e54d3.mp4 ### AFTER WITHOUT PAGINATION https://user-images.githubusercontent.com/60598000/129912800-bb62a10e-1fe9-4f6d-bfaf-366b60cc452f.mp4 ### AFTER WITH PAGINATION https://user-images.githubusercontent.com/60598000/129912887-61e8525d-88e3-4b57-b774-1b9a7c16a822.mp4 ### TESTING INSTRUCTIONS 1. Open Explore 2. Open the Change Dataset modal 3. Close the top warning 4. Make sure no excessive blank space appears at the bottom ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #16291 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
