nytai commented on a change in pull request #14955:
URL: https://github.com/apache/superset/pull/14955#discussion_r691526508
##########
File path: superset/views/base.py
##########
@@ -312,6 +312,11 @@ def menu_data() -> Dict[str, Any]:
brand_text = appbuilder.app.config["LOGO_RIGHT_TEXT"]
if callable(brand_text):
brand_text = brand_text()
+ build_number = ""
+ try:
+ build_number = appbuilder.app.config["BUILD_NUMBER"]
+ except Exception as ex:
+ logger.debug("BUILD_NUMBER is missing from the config", ex)
Review comment:
this shouldn't be necessary if you add a default value in config.py,
(either empty string or `None`). Config values should never be undefined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
