michael-s-molina opened a new pull request #16334:
URL: https://github.com/apache/superset/pull/16334


   ### SUMMARY
   Changes the `DatabaseSelector` and `TableSelector` to use the new Select 
component
   - Make the selects more similar to the rest of the application with the 
labels on top and no tags
   - Adds pagination and lazy loading to the database select
   - Adds lazy loading to the schemas select
   - Adds lazy loading to the tables select
   - Removes the number of items in a select due to lazy loading
   - Improves the layout of the virtual dataset
   - Migrates the table and view icons to the new Icons component
   - Adjusts the size of the table, view, certification, and warning icons
   
   @junlincc @rusackas @villebro @jinghua-qa @rosemarie-chiu
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/129966548-62b6efa8-44a5-43fa-b9d1-8a59f13b9024.mov
   
   
https://user-images.githubusercontent.com/70410625/129966741-03fb26fb-4b53-45eb-881d-d2a115953b86.mov
   
   PS: There's an error that is also happening on master when we try to change 
the table of a saved dataset. It raises "An error has occurred". On the server 
logs, we can see a 401. @villebro This is not related to this PR but if it's 
something simple we can add the fix here.
   
   ### TESTING INSTRUCTIONS
   Check the videos for instructions.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to