sabiroid commented on issue #16209: URL: https://github.com/apache/superset/issues/16209#issuecomment-902121572
@mistercrunch, when you say "make an inventory of all the places we read global context", do you mean to pass references to those places over to `CELERY_FLASK_METADATA_EXTRACTOR` and `CELERY_FLASK_METADATA_INITIALIZER`? That sounds looks like a really good idea, so the user setting Superset up won't need to import `flask` context-global variables themselves in their code. By the way, just to clarify, on the async workers we don't read the global context by `CELERY_FLASK_METADATA_INITIALIZER`, we write into it. But we read it by `CELERY_FLASK_METADATA_EXTRACTOR` on the main (i.e. "synchronous") side. ON the async side the global context is read by the `DB_CONNECTION_MUTATOR` to set up authorization parameters and granular source information. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
