john-bodley commented on a change in pull request #16367:
URL: https://github.com/apache/superset/pull/16367#discussion_r693079356
##########
File path: superset/config.py
##########
@@ -994,6 +994,8 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC(
# If set to true no notification is sent, the worker will just log a message.
# Useful for debugging
ALERT_REPORTS_NOTIFICATION_DRY_RUN = False
+# Allowed notification methods: Email, Slack
+ALERT_REPORTS_ALERTS_NOTIFICATION_METHODS = ["Email", "Slack"]
Review comment:
@graceguo-supercat I think it would be preferable to reuse
[this](https://github.com/apache/superset/blob/3adf8e85cde0dec27be497ea3379d87eb2b30e4b/superset/models/reports.py#L59)
enum. Also what happens if you make this an empty list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
