ktmud commented on a change in pull request #16362:
URL: https://github.com/apache/superset/pull/16362#discussion_r693122888
##########
File path:
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
##########
@@ -104,6 +108,12 @@ const columnsContainAllMetrics = (
);
};
+export type DndMetricSelectProps = DndControlProps<ValueType> & {
+ savedMetrics: savedMetricType[];
+ columns: ColumnMeta[];
+ datasourceType?: DatasourceType;
+};
+
export const DndMetricSelect = (props: any) => {
Review comment:
TODO: get rid of this `any`. Currently `DndMetricSelectProps` will
conflict with too many things within this function. This file needs a bigger
overhaul.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
