kgabryje commented on a change in pull request #16391:
URL: https://github.com/apache/superset/pull/16391#discussion_r693528834
##########
File path:
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
##########
@@ -229,6 +230,7 @@ class SliceHeaderControls extends React.PureComponent<
value.behaviors?.includes(Behavior.INTERACTIVE_CHART),
)
.find(([key]) => key === slice.viz_type);
+ const emitCrossFilter = slice.form_data?.emit_filter;
Review comment:
Can we name it sth like `canEmitCrossFilter`? It might be mistaken for a
function that emits a cross filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
