leakingoxide opened a new pull request #6544: Make owner a m2m relation on 
datasources
URL: https://github.com/apache/incubator-superset/pull/6544
 
 
   This is a PR for https://github.com/apache/incubator-superset/issues/6471.
   
   I'm not sure about `/save/` endpoint for datasources, because ideally I 
would just pass a list of ids in `update_from_object`. This, however, doesn't 
seem to work in sqlalchemy, and the only solution that I managed to get 
working, was retrieving a list of `User` objects from the database earlier. I'm 
open to suggestions how it could be done differently.
   
   I'm also not quite sure about the migration, because every time I try to 
upgrade it alone on postgresql it hangs (probably 
https://github.com/apache/incubator-superset/issues/1260), and sqlite doesn't 
support all of the operations (removing the column). Which makes me unable to 
do proper testing for owner->owners data migration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to