ravimakhija opened a new pull request #16400: URL: https://github.com/apache/superset/pull/16400
### SUMMARY Currently the NA values used in `superset/config.py` are imported via `from pandas.io.parsers import STR_NA_VALUES`. In `pandas>=1.3.0` this approach breaks due to some refactoring in pandas and leads to the following exception: `ImportError: cannot import name 'STR_NA_VALUES' from 'pandas.io.parsers'` In this PR, the import is refactored to use `from pandas._libs.parsers import STR_NA_VALUES`, which imports the same NA values as before but uses the original pandas module. This refactoring should work with both the current `pandas==1.2.5` dependency, as well as more recent versions e.g. `pandas==1.3.0`. Finally, since this import uses a Cython extension, the corresponding pylint tox environment was modified with the `--extension-pkg-allow-list` option to avoid a false positive when running pylint. ### TESTING INSTRUCTIONS Upgrading the pandas package that superset uses to `pandas>=3.0` and starting up superset should reproduce the `ImportError` caused by the dependency issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
