michael-s-molina commented on a change in pull request #16397:
URL: https://github.com/apache/superset/pull/16397#discussion_r694243235
##########
File path: superset/views/base_api.py
##########
@@ -490,6 +490,12 @@ def related(self, column_name: str, **kwargs: Any) ->
FlaskResponse:
# handle pagination
page, page_size = self._handle_page_args(args)
+
+ ids = args.get("include_ids")
+ if page and ids:
+ # pagination with forced ids is not supported
+ return self.response_400()
Review comment:
Should we send a 422 instead?
https://softwareengineering.stackexchange.com/questions/329229/should-i-return-an-http-400-bad-request-status-if-a-parameter-is-syntactically
##########
File path: superset/views/base_api.py
##########
@@ -490,6 +490,12 @@ def related(self, column_name: str, **kwargs: Any) ->
FlaskResponse:
# handle pagination
page, page_size = self._handle_page_args(args)
+
+ ids = args.get("include_ids")
+ if page and ids:
+ # pagination with forced ids is not supported
+ return self.response_400()
Review comment:
Should we send a `422` instead?
https://softwareengineering.stackexchange.com/questions/329229/should-i-return-an-http-400-bad-request-status-if-a-parameter-is-syntactically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
