villebro commented on a change in pull request #16421:
URL: https://github.com/apache/superset/pull/16421#discussion_r694796893
##########
File path:
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -152,7 +152,7 @@ const FilterFocusHighlight = React.forwardRef(
},
);
-class ChartHolder extends React.Component {
+export class ChartHolder extends React.Component {
Review comment:
is this export needed somewhere?
##########
File path:
superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx
##########
@@ -77,7 +78,7 @@ Click here to edit [markdown](https://bit.ly/1dQOfRK)`;
const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.');
-class Markdown extends React.PureComponent {
+export class Markdown extends React.PureComponent {
Review comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
