villebro commented on pull request #16437: URL: https://github.com/apache/superset/pull/16437#issuecomment-905634756
@stephenLYZ : > Frontend looks good to me! Thanks for the fixing. Is there any other state that can be maintained on the frontend only? Good question; I did briefly look into moving a few other properties to the frontend, but the obvious ones in this endpoint (`can_add` and `can_download`) seemed like they were actually better handled in the backend. But I will definitely be on the lookout for similar simplifications in subsequent PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
