mistercrunch closed pull request #6534: Fix string value displaying NaN
URL: https://github.com/apache/incubator-superset/pull/6534
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/src/visualizations/Table/Table.js
b/superset/assets/src/visualizations/Table/Table.js
index 23cdc07d3b..e8742afb17 100644
--- a/superset/assets/src/visualizations/Table/Table.js
+++ b/superset/assets/src/visualizations/Table/Table.js
@@ -174,7 +174,15 @@ function TableVis(element, props) {
return null;
})
.classed('text-right', d => d.isMetric)
- .attr('title', d => (!Number.isNaN(d.val) ? formatValue(d.val) : null))
+ .attr('title', (d) => {
+ if (typeof d.val === 'string') {
+ return d.val;
+ }
+ if (!Number.isNaN(d.val)) {
+ return formatValue(d.val);
+ }
+ return null;
+ })
.attr('data-sort', d => (d.isMetric) ? d.val : null)
// Check if the dashboard currently has a filter for each row
.classed('filtered', d =>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
