pkdotson commented on a change in pull request #16393:
URL: https://github.com/apache/superset/pull/16393#discussion_r696909249
##########
File path: superset-frontend/src/components/ListView/CardSortSelect.tsx
##########
@@ -16,24 +16,24 @@
* specific language governing permissions and limitations
* under the License.
*/
-import React, { useState } from 'react';
-import { styled, withTheme, SupersetThemeProps, t } from '@superset-ui/core';
-import { PartialThemeConfig, Select } from 'src/components/Select';
+import React, { useState, useMemo } from 'react';
+import { styled, t } from '@superset-ui/core';
+import { Select } from 'src/components';
+import { FormLabel } from 'src/components/Form';
+import { SELECT_WIDTH } from './utils';
import { CardSortSelectOption, FetchDataConfig, SortColumn } from './types';
-import { filterSelectStyles } from './utils';
-
-const SortTitle = styled.label`
- font-weight: bold;
- line-height: 27px;
- margin: 0 0.4em 0 0;
-`;
const SortContainer = styled.div`
display: inline-flex;
font-size: ${({ theme }) => theme.typography.sizes.s}px;
- padding-top: ${({ theme }) => theme.gridUnit}px;
+ align-items: center;
text-align: left;
+
+ & > div {
+ width: ${SELECT_WIDTH}px;
Review comment:
curious to know if this would ever need to be change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
