[GitHub] [superset] ktmud edited a comment on pull request #16393: refactor: Changes the list views to use the new Select component

[GitBox]

ktmud edited a comment on pull request #16393:
URL: https://github.com/apache/superset/pull/16393#issuecomment-907342697


   Here are more UX issues with this Select components:  🤦 
   
   1. When there is no selected value,`me` is not ranked the first anymore:
      ### Now
      <img width="389" alt="Xnip2021-08-27_09-52-13" 
src="https://user-images.githubusercontent.com/335541/131162032-3a545d17-349c-45c5-b1e6-a12546ce18ec.png";>
      
      ### Before
      <img width="523" alt="Xnip2021-08-27_09-50-24" 
src="https://user-images.githubusercontent.com/335541/131161837-385ee56d-95f1-467a-b255-33493e57e273.png";>
      
   2. I was not able to find myself while searching my full name:
       ### Now
      <img width="300" alt="Xnip2021-08-27_09-54-04" 
src="https://user-images.githubusercontent.com/335541/131162221-8fac49cb-0c48-4922-972d-c114e1dcddd1.png";>
      
      ### Before
      <img width="260" alt="Xnip2021-08-27_09-53-31" 
src="https://user-images.githubusercontent.com/335541/131162253-704c6ea0-af7f-4959-9fed-f205dab8378d.png";>
   3. Not able to find other filter options when there is a selected value in 
the URL parameters (to test this, just select a value and refresh the page):
      ### Now
      <img width="369" alt="Xnip2021-08-27_09-56-48" 
src="https://user-images.githubusercontent.com/335541/131162629-0f9555f4-2955-46b9-b7b8-9e2f52ad4f90.png";>
   
   4. After selecting some values, clicking on the main nav links ("Charts"  or 
"Dashboards") updates the URL but does not reset the filters.
   
   
   Please tag me again when these issues are fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org