graceguo-supercat edited a comment on pull request #16154: URL: https://github.com/apache/superset/pull/16154#issuecomment-909743589
Thanks @michael-s-molina and @m-ajay I also played a little bit, here is my feedback:  1. only parent (top level filters) are shown in the filters list 2. In the edit mode, nested filters are also dragable and could be reordered. But there is no use to do this change, since nested filters don't show up in the filters list. In my opinion, we should probably not offer any action that is no use :) 3. it's pretty easy to hit `Cannot read property 'tagName' of null` error if i move nested filters. I understand we want to allow user fully control the nested filter so we show them as first-class filter component. But make user move them up and down do not make sense to me. So my suggestion is: - make child filter always next to parent filter, - when user moves parent filter, children should be moved along, - children (nested filters) itself, should not be dragable or rearrangeable. @m-ajay @michael-s-molina @junlincc please let me know your opinion about this behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
