mistercrunch commented on a change in pull request #6541: [SIP-14] remove
dependency on yarn in favor of npm
URL:
https://github.com/apache/incubator-superset/pull/6541#discussion_r242751385
##########
File path: superset/assets/package.json
##########
@@ -67,6 +67,7 @@
"bootstrap-slider": "^10.0.0",
"brace": "^0.11.1",
"classnames": "^2.2.5",
+ "core-js": "^2.6.0",
Review comment:
Without `core-js`, I get build failures like:
```
ERROR in
./node_modules/@superset-ui/chart/node_modules/@superset-ui/core/esm/models/Registry.js
Module not found: Error: Can't resolve 'core-js/modules/es6.array.iterator'
in
'/home/travis/build/mistercrunch/superset/superset/assets/node_modules/@superset-ui/chart/node_modules/@superset-ui/core/esm/models'
@
./node_modules/@superset-ui/chart/node_modules/@superset-ui/core/esm/models/Registry.js
1:125-168
@
./node_modules/@superset-ui/chart/node_modules/@superset-ui/core/esm/index.js
@
./node_modules/@superset-ui/chart/esm/registries/ChartTransformPropsRegistrySingleton.js
@ ./node_modules/@superset-ui/chart/esm/index.js
@ ./src/addSlice/AddSliceContainer.jsx
@ ./src/addSlice/App.jsx
@ ./src/addSlice/index.jsx
@ multi babel-polyfill ./src/preamble.js ./src/addSlice/index.jsx
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
