[GitHub] [superset] jinghua-qa opened a new issue #16552: [edit dataset] error will show if change dataset from edit dataset modal

[GitBox]

jinghua-qa opened a new issue #16552:
URL: https://github.com/apache/superset/issues/16552


   when i try to change dataset when i am in edit dataset modal, the columns of 
old dataset and new dataset got messed up and the change are saved to my old 
dataset, then when i try to do the chart, error msg will show also the 
dashboard with old dataset is broken.
   
   I think if user is not suppose to change dataset in edit modal we should got 
warning msg before we save, or maybe disable the drop down list in edit modal 
so that user wont be able to do the change?
   
   
https://user-images.githubusercontent.com/81597121/131720932-f35bb622-0b11-415c-8374-5a8e78c474f5.mov
   
   <img width="1781" alt="Screen Shot 2021-09-01 at 10 40 24 AM" 
src="https://user-images.githubusercontent.com/81597121/131720950-86b025d5-5e26-412e-b48d-911c498ec7d1.png";>
   <img width="1792" alt="Screen Shot 2021-09-01 at 10 33 23 AM" 
src="https://user-images.githubusercontent.com/81597121/131720953-52e92f24-9d77-4e22-9e10-ceabfcaef995.png";>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org