ktmud commented on issue #16553: URL: https://github.com/apache/superset/issues/16553#issuecomment-910615443
This is a great starting point! Do we want to have some more specific style guide, too? For example: - React props should go with the component itself, and not in a `types.ts` file - Don't put multiple components in a React file (should be capturable by eslint) - Use `type ...` for Reat props and `interface ...` for all other places - Prefer TypeScript string literals type over Enums and const variables - How to use variables in Emotion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
