shawnzhu commented on issue #16557:
URL: https://github.com/apache/superset/issues/16557#issuecomment-910949849


   @nytai Thanks for the feedback!
   
   I've seen its creates a new record in `ab_view_menu` for a new `sqltable` 
(i.e., a dataset in superset) plus a new record in `ab_permission_view`, so 
that it could manage dataset access via editing roles just like how to manage 
database access as well.
   
   > Is this proposal mainly to improve this UI/workflow by adding this control 
directly on the dataset edit modal instead of in the edit roles menu? ​This 
would also allow dataset owners to grant access instead of having to ask 
someone with edit roles access to grant access?
   
   Yes and Yes. and I think such workflow should apply to database access 
management as well, so that a database/dataset owner can choose who can access 
this database/dataset. And such permission granting can be override by those 
who with edit roles access.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to