michael-s-molina commented on a change in pull request #16587:
URL: https://github.com/apache/superset/pull/16587#discussion_r702149336
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -416,6 +427,7 @@ const Select = ({
allowNewOptions,
initialOptions,
isSingleMode,
+ onChange,
Review comment:
@geido onChange was not on the list of dependencies in your original PR.
It's a good idea to check that this function is being memoized 😉
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -416,6 +427,7 @@ const Select = ({
allowNewOptions,
initialOptions,
isSingleMode,
+ onChange,
Review comment:
@geido `onChange` was not on the list of dependencies in your original
PR. It's a good idea to check that this function is being memoized 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
