john-bodley commented on a change in pull request #16589:
URL: https://github.com/apache/superset/pull/16589#discussion_r702370875
##########
File path: tests/integration_tests/utils/public_interfaces_test.py
##########
@@ -14,19 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=no-self-use
+from typing import Any, Callable, Dict
+
import pytest
-from superset.sql_lab import dummy_sql_query_mutator
from superset.utils.public_interfaces import compute_hash, get_warning_message
-from tests.integration_tests.base_tests import SupersetTestCase
# These are public interfaces exposed by Superset. Make sure
# to only change the interfaces and update the hashes in new
# major versions of Superset.
-hashes = {
- dummy_sql_query_mutator: "Kv%NM3b;7BcpoD2wbPkW",
-}
+hashes: Dict[Callable[..., Any], str] = {}
Review comment:
There was issues in referencing the `app.config["SQL_QUERY_MUTATOR"]
because i) the app was the test rather than the default config, and ii) the
test wasn't running within an app context. Furthermore it's unclear why the
default SQL query mutator was needed explicit checking compared to say any
other of the default interfaces.
##########
File path: tests/integration_tests/utils/public_interfaces_test.py
##########
@@ -14,19 +14,16 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=no-self-use
+from typing import Any, Callable, Dict
+
import pytest
-from superset.sql_lab import dummy_sql_query_mutator
from superset.utils.public_interfaces import compute_hash, get_warning_message
-from tests.integration_tests.base_tests import SupersetTestCase
Review comment:
Unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
