[GitHub] [superset] aniaan opened a new pull request #16624: fix(dataset): create es-view dataset raise exception #16623

[GitBox]

aniaan opened a new pull request #16624:
URL: https://github.com/apache/superset/pull/16624


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Fix the error of creating es-view dataset
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   before:
   <img width="964" alt="create-error" 
src="https://user-images.githubusercontent.com/40813941/132386895-4fde5f21-3fda-4009-a0f6-88ed13ce6a58.png";>
   
   after:
   <img width="1358" alt="截屏2021-09-08 上午1 31 27" 
src="https://user-images.githubusercontent.com/40813941/132386921-93572a94-dc44-41b2-a438-a318c4daa74a.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   Manually create a dataset of ES-View type to see if it is successfully 
created. The same is true for view types of other databases, but because of the 
limited conditions, I only tested ES + MySQL.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #16623
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org