[GitHub] [superset] pkdotson commented on pull request #16454: feat: add certifiedby & certification details fields to the edit dataset columns fields

Thu, 09 Sep 2021 08:27:12 -0700 


pkdotson commented on pull request #16454:
URL: https://github.com/apache/superset/pull/16454#issuecomment-916202861


   > @pkdotson below my feedback after manual testing:
   > 
   > * Metrics use a tooltip for both fields. The tooltip is missing for both 
fields in Columns and Calculated columns. I think we should have it there too 
for consistency
   > 
   > ![Screen Shot 2021-09-09 at 14 53 
51](https://user-images.githubusercontent.com/60598000/132681153-9b14f803-912e-4f77-b03c-5cb1a36be69b.png)
   > 
   > * The certified icon should show also in the Dataset panel. However, this 
is happening only for the Metrics currently
   > 
   > ![Screen Shot 2021-09-09 at 14 56 
19](https://user-images.githubusercontent.com/60598000/132681505-776b20bb-fefb-4362-ace8-1c6caae9218e.png)
   
   Hey @geido the change has already been made in superset-ui. I just pulled in 
the latest code should have change. I'll spin up new test env.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to