jinghua-qa commented on pull request #16689: URL: https://github.com/apache/superset/pull/16689#issuecomment-918700712
@graceguo-supercat, we want to make this change because of 2 reasons: 1, For header and markdown component, the trashcan icon is not shown when hovering over (shown by click), which is inconsistent behavior with the rest of other dashboard components. 2,This inconsistent behavior sometimes could cause confusion. For example, when we have a markdown in a row, when user hovering over the markdown, a trashcan icon will show because of the Row component and makes user think that icon is to delete the markdown, but clicking on that trash icon will delete the Row with all components because the trash icon is shown when hovering a row and markdown trash icon wont show until you click on it.  We got this feedback from a first time user feeback so we suggest that 1, to make trashcan icon show when hovering over for all components 2, when trashcan icon show for header and markdown, it will show in the right top conner inside the component so that it is clear to the user what is deleting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
