mistercrunch commented on a change in pull request #6540: Make boto3/botocore
installation optional
URL:
https://github.com/apache/incubator-superset/pull/6540#discussion_r243670966
##########
File path: superset/db_engine_specs.py
##########
@@ -1065,6 +1064,9 @@ def convert_to_hive_type(col_type):
convert_to_hive_type(column_info['type'])))
schema_definition = ', '.join(column_name_and_type)
+ # Optional dependency
+ import boto3 # pylint: disable=import-error
Review comment:
I feel like it's better to raise the error `ModuleNotFoundError: No module
named boto3'` than the `NameError: name 'boto3' is not defined`. The former
calls the action of installing the module more clearly.
Mind if I stick with what I had?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
