villebro commented on a change in pull request #16692:
URL: https://github.com/apache/superset/pull/16692#discussion_r709420796
##########
File path: superset/views/core.py
##########
@@ -834,7 +834,7 @@ def explore( # pylint: disable=too-many-locals
}
try:
datasource_data = datasource.data if datasource else
dummy_datasource_data
- except (SupersetException, SQLAlchemyError):
+ except Exception: # pylint: disable=broad-except
Review comment:
We should try to avoid catching broad `Exception`s whenever possible. I
believe there was a PR for specifying what types of exceptions are to be
expected from a db engine spec under normal circumstances. Let me see if I can
find it..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
