[GitHub] [superset] junlincc edited a comment on pull request #16454: feat: add certifiedby & certification details fields to the edit dataset columns fields

[GitBox]

junlincc edited a comment on pull request #16454:
URL: https://github.com/apache/superset/pull/16454#issuecomment-920430052


   @etr2460 thanks for the review. tested locally. 
   
   certification feature is added column and calculated columns ✅
   certified items goes on top of the list in each section ✅
   edited other uncertified fields did not affect the certified ones ✅ 
   2 issues need to be addressed before merging (?) 
   
   1) icon alignment <img width="313" alt="Screen Shot 2021-09-15 at 3 24 59 
PM" 
src="https://user-images.githubusercontent.com/67837651/133518021-fffb7d6c-2789-402d-a4df-4637ab4f861f.png";>
   <img width="234" alt="Screen Shot 2021-09-15 at 3 24 51 PM" 
src="https://user-images.githubusercontent.com/67837651/133518225-dc0eda21-b3ea-4d9b-a654-3dec2ff5405b.png";>
   
   2) when user click on the pencil icon from dataset crud view and open edit 
dataset modal, certification details are not showing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org