graceguo-supercat opened a new issue #16719: URL: https://github.com/apache/superset/issues/16719
#### How to reproduce the bug 1. pick a dataset, for example baby names, and create a new chart 2. in Explore view, edit dataset, create a few custom Metric, for example, MAX(num) or Min(num) 3. add multiple metrics into Metrics control. Chart can display nicely. 4. Edit dataset again, remove newly added Max(num). Save changes. 5. Chart is broken, the whole Metrics control is empty. refresh chart will see Empty query? error #### Screenshots <img width="1405" alt="Screen Shot 2021-09-16 at 9 27 15 AM" src="https://user-images.githubusercontent.com/27990562/133649883-556c7cb1-9ded-4cbc-b27f-b4b4ce4e2210.png";> ### Environment latest master ### Checklist Make sure to follow these steps before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any. - [x] I have reproduced the issue with at least the latest released version of superset. - [x] I have checked the issue tracker for the same issue and I haven't found one similar. ### Additional context This issue is introduced by PR #16196. https://github.com/apache/superset/blob/a547dcb73ef57861d41d46bbfe309cdef97d5b54/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.jsx#L256 This behavior probably have to be fixed. We have many dataset that was used very long time, and it might always has been some updates over the time. Because one of Metric is not available, the whole chart is broken. **_There is no way for user to realize what is wrong and how to fix it_**, this is the biggest problem. cc @junlincc @kgabryje @ktmud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/133649883-556c7cb1-9ded-4cbc-b27f-b4b4ce4e2210.png"](https://user-images.githubusercontent.com/27990562/133649883-556c7cb1-9ded-4cbc-b27f-b4b4ce4e2210.png"){kind=link}