eschutho opened a new pull request #16753:
URL: https://github.com/apache/superset/pull/16753


   ### SUMMARY
   Currently, if you were to save a query without running it, the redux store 
does not update, and the save query button will save the old query. This 
updates the action to trigger the redux action in all cases. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: 
   
   
   
https://user-images.githubusercontent.com/5186919/134090374-7a8e63f0-3212-4e87-8722-1655432b9d0a.mp4
   
   After: 
   
   
https://user-images.githubusercontent.com/5186919/134090396-348bbbbe-4d49-454e-a5cb-1d8a2f579c0f.mov
   
   
   
   ### TESTING INSTRUCTIONS
   Write a query and then save it without hitting "run". Copy the link and 
paste it in a new window. The saved query should have the correct sql 
statement. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to