eschutho opened a new pull request #16754: URL: https://github.com/apache/superset/pull/16754
### SUMMARY When closing multiple tabs, there would sometimes be errors because we were fetching function names with a null db. This checks that the db is present before updating. If the db is not present, the function names will fetch on the left toolbar db change method. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF before: https://user-images.githubusercontent.com/5186919/134093911-62487bda-3467-4e05-988f-00dc8498c09b.mov ### TESTING INSTRUCTIONS save a query, copy it and open it in a window. Open a bunch of saved queries so that you have about 4 tabs loading all at once on a page load, then close them one by one. There should be no errors, and your database should update. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
