betodealmeida commented on a change in pull request #16763:
URL: https://github.com/apache/superset/pull/16763#discussion_r713316546
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -589,21 +589,22 @@ function ChartList(props: ChartListProps) {
window.location.assign('/chart/add');
},
});
- }
- if (isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT)) {
- subMenuButtons.push({
- name: (
- <Tooltip
- id="import-tooltip"
- title={t('Import charts')}
- placement="bottomRight"
- >
- <Icons.Import data-test="import-button" />
- </Tooltip>
- ),
- buttonStyle: 'link',
- onClick: openChartImportModal,
- });
+
Review comment:
Note line 580 above. I moved this to inside the `if (canCreate)` block.
Similar for other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
