villebro commented on pull request #16776: URL: https://github.com/apache/superset/pull/16776#issuecomment-924641846
> I was more thinking of when some column changed from a datetime type to non datetime, the previously inferred is_dttm will be retained. But like I said, I think this case is also OK. It's much more likely to want to force a non-dttm to dttm than vice versa. CI seems to be so flaky we still have some time to iterate.. :D I wonder if this would be the best flow: If the column exists and the raw datatype has changed, reinfer `is_dttm`. Therefore, if the raw datatype is unchanged, `is_dttm` is also unchanged. This would have the drawback of disabling `is_dttm` when `VARCHAR(10)` is changed to `VARCHAR(11)` or `TEXT` or some other non-temporal type, but I assume this is fairly uncommon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
