geido commented on pull request #16761: URL: https://github.com/apache/superset/pull/16761#issuecomment-925899886
> Found 2 cosmetic issues in data table (can not repo on dev and prod): > 1, the row bubble take some time to load when switching between data and sample Could not repro https://user-images.githubusercontent.com/60598000/134532383-88289411-ccca-4694-ae05-acc785b1dfe1.mp4 > 2, rolling down the data table and sample table the column title row is rolling too Could not repro as well https://user-images.githubusercontent.com/60598000/134532462-0ace75ef-fbcb-4862-bf82-5bf03b69dc6a.mp4 > 3, when adding annotation, need to click ok twice to add one annotation I could reproduce this one and I am going to tackle it in the appropriate PR. I also finished all the test cases and could not find any blocker. So I believe we are safe to proceed @jinghua-qa @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
