lyndsiWilliams commented on a change in pull request #16734:
URL: https://github.com/apache/superset/pull/16734#discussion_r715255725
##########
File path: superset-frontend/cypress-base/package.json
##########
@@ -10,14 +10,15 @@
"author": "Apcahe",
"license": "Apache-2.0",
"dependencies": {
- "@cypress/code-coverage": "^3.9.2",
+ "@cypress/code-coverage": "^3.9.11",
"@superset-ui/core": "^0.17.42",
"react-dom": "^16.13.0",
"rison": "^0.1.1",
"shortid": "^2.2.15"
},
"devDependencies": {
- "cypress": "^6.3.0",
+ "@cypress/webpack-dev-server": "^1.6.0",
Review comment:
I ran all the e2e tests with and without this dependency. There are
actually more passing tests without this, so I've removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
