villebro opened a new pull request #16828: URL: https://github.com/apache/superset/pull/16828
### SUMMARY The fix in #16460 didn't address the special case of numeric filter values sometimes being temporal filters. It also introduced a new util for formatting filter values which whose functionality was already covered by the much more comprehensive `getDataRecordFormatter` factory function, which also handles time and number formatting. The redundant formatter is removed and replaced by `getDataRecordFormatter` which was already being used for formatting the options in the Select component. ### AFTER  ### BEFORE  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
