AAfghahi commented on a change in pull request #16628:
URL: https://github.com/apache/superset/pull/16628#discussion_r715830844
##########
File path: superset/models/core.py
##########
@@ -249,6 +250,14 @@ def parameters(self) -> Dict[str, Any]:
return parameters
+ @property
+ def parameters_schema(self) -> Dict[str, Any]:
+ try:
+ parameters_schema = self.db_engine_spec.parameters_json_schema()
# type: ignore # pylint: disable=line-too-long,useless-suppression
Review comment:
when I had this with just type: ignore it was failing the python lint
test. So I emulated this line:
https://github.com/apache/superset/blob/master/superset/models/core.py#L246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
