geido opened a new pull request #16851:
URL: https://github.com/apache/superset/pull/16851


   ### SUMMARY
   This PR fixes several issues related to the undo functionality in native 
filters. It stores the latest form data and adds it back to the form when the 
user removes a filter and then undoes the removal. 
   
   ### BEFORE
   See issue #16821
   
   ### AFTER
   
   
https://user-images.githubusercontent.com/60598000/134869243-74396a24-218d-4fc2-beec-27b1ed8e3879.mp4
   
   ### TESTING INSTRUCTIONS
   1. Open a Dashboard with native filters enabled
   2. Add a filter
   3. Remove the filter
   4. Undo your action and make sure the latest data was preserved
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #16821
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to