villebro commented on a change in pull request #16822:
URL: https://github.com/apache/superset/pull/16822#discussion_r716516482
##########
File path: superset/db_engine_specs/base.py
##########
@@ -952,9 +952,11 @@ def select_star( # pylint:
disable=too-many-arguments,too-many-locals
if (show_cols or latest_partition) and not cols:
cols = database.get_columns(table_name, schema)
- if show_cols:
- fields = cls._get_fields(cols)
quote = engine.dialect.identifier_preparer.quote
+ if show_cols:
+ # Explicitly quote all column names, as BigQuery doesn't quote
column
+ # names that are also identifiers (eg, "limit") by default.
+ fields = [text(quote(col["name"])) for col in cols]
Review comment:
While I agree this is probably quite safe, I think @eschutho's
recommendation to add a property for forcing quotes would be a good solution,
so as to avoid adding workarounds that aren't necessary for all engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
