geido edited a comment on issue #11680: URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364
@etr2460 I don't think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owner in the Datasource settings. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is still not merged so this might be a good opportunity to think about doing it depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlincc There is another implementation which is using the paginated fetch instead and that's in the Properties modal. I have an env with more than 10 owners (10 is the default page size of the new Select) and could not spot any problem. I am about to merge this PR containing the changes. This can be a good opportunity to validate this issue against the new implementation https://github.com/apache/superset/pull/16445. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
