betodealmeida commented on a change in pull request #16859:
URL: https://github.com/apache/superset/pull/16859#discussion_r717121839
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1662,9 +1663,9 @@ def before_update(
# Check whether the relevant attributes have changed.
state = db.inspect(target) # pylint: disable=no-member
-
- for attr in ["database_id", "schema", "table_name"]:
+ for attr in ["schema", "table_name"]:
Review comment:
We shouldn't remove `database_id` here, otherwise someone might create a
dataset with the same database ID, schema and table name. We should figure out
why database ID is coming as null when updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
