hughhhh commented on a change in pull request #16859:
URL: https://github.com/apache/superset/pull/16859#discussion_r718073238
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -133,6 +138,27 @@ const ResultSetErrorMessage = styled.div`
padding-top: ${({ theme }) => 4 * theme.gridUnit}px;
`;
+const updateDataset = async (
+ datasetId: number,
+ sql: string,
+ columns: Array<Record<string, any>>,
+ overrideColumns: boolean,
+) => {
+ const endpoint =
`api/v1/dataset/${datasetId}?override_columns=${overrideColumns}`;
Review comment:
We still need it to bypass the column uniqueness check:
https://github.com/apache/superset/blob/ac1d779a30ea8b009007b02b2bbb7cbe254ec16c/superset/datasets/commands/update.py#L138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]